upcoming: [DI-23083] - Migrated CloudPulseTimeRangeSelect to DateTimeRangePicker #11573
Conversation
… for preset value
…evious preset selected
nikhagra-akamai
changed the title
nikhagra-akamai
requested review from
carrillo-erik and
abailly-akamai
and removed request for
a team
| @@ -249,6 +248,9 @@ export const DateTimePicker = ({ | |||
| padding: 0, | |||
| }), | |||
| }, | |||
| field: { | |||
| readOnly: true, | |||
There was a problem hiding this comment.
to avoid user to type inside time select otherwise it'll break the UI
| handleTimeDurationChange(timerDuration); | ||
| handleTimeDurationChange({ | ||
| ...timeDuration, | ||
| end: convertToGmt(timeDuration.end), |
There was a problem hiding this comment.
converting to gmt because api request accepts date in gmt format
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 488 passing tests on test run #4 ↗︎
|
There was a problem hiding this comment.
Thanks for the contribution 👍
Am seeing quite a few problems with this implementation so far:
Mismatch between selected Time Zones when opening the select back up
Shouldn't the date selection clear when I clear the dashboard selection?
Does the UI stipulate having to display the time zone along with the selection?
Why is GMT enforced?
| const [startDateTime, setStartDateTime] = useState<DateTime | null>( | ||
| startDateTimeValue | ||
| startDateTimeValue ?? | ||
| DateTime.now().set({ second: 0 }).minus({ minutes: 30 }) |
There was a problem hiding this comment.
Has there been discussions around setting this to the user time zone?
| @@ -249,6 +248,9 @@ export const DateTimePicker = ({ | |||
| padding: 0, | |||
| }), | |||
| }, | |||
| field: { | |||
| readOnly: true, | |||
Description 📝
Migrated Time range select component in ACLP to Date time range picker with presets component.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
10th February 2025
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅